Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )
Change subject: mb/google/dedede: Enable trackpad support ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... PS4, Line 36: EDGE_SINGLE
Why EDGE_SINGLE? At pad, we just configure the trigger to be level to pass the signal as is to APIC.
Done
https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... PS4, Line 36: PAD_CFG_GPI_APIC
We would want to also enable wake on trackpad line.
I see GPE STS set in PMC reg corresponding to B3(GPE_DW0_03), should trigger wake.
https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... PS2, Line 24: .rise_time_ns = 66, : .fall_time_ns = 90, : .data_hold_time_ns = 350
Hello Karthik, […]
Hi Karthik,
yes, the mean is around 350Khz