1 Sep
2022
1 Sep
'22
10 p.m.
Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67301 )
Change subject: soc/amd/common/block/apob: Add hashed APOB support ......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/apob/apob_cache.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-157921): https://review.coreboot.org/c/coreboot/+/67301/comment/580801a0_c1844572 PS1, Line 268: if (CONFIG(SOC_AMD_COMMON_BLOCK_APOB_HASH)) { braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/67301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I241968b115aaf41af63445410660bdd5199ceaba
Gerrit-Change-Number: 67301
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 01 Sep 2022 20:00:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment