Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36708 )
Change subject: AGESA: Select CBMEM_STAGE_CACHE with HAVE_ACPI_RESUME
......................................................................
Patch Set 1: Code-Review+2
Very good! Although, I don't know if CBMEM_STAGE_CACHE security concerns are serious enough: if yes, some people may want to be able to sacrifice ACPI_RESUME (I could try to make these options selectable in a follow-up commit if really necessary)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36708
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11db0c883b6e39473d02e92b14cb3c6302aa728e
Gerrit-Change-Number: 36708
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 10 Nov 2019 17:57:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment