Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43166 )
Change subject: mb/siemens/mc_apl1: Use OPCODE menu set up of fast SPI driver
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43166/1/src/mainboard/siemens/mc_ap...
File src/mainboard/siemens/mc_apl1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/43166/1/src/mainboard/siemens/mc_ap...
PS1, Line 204: fast_spi_set_opcode_menu();
This is not seem mainboard specific? Any reason it happens here? BTW who is locking things down?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43166
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98457a0b0652f746734ee4204e10acd09b6e5fda
Gerrit-Change-Number: 43166
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: uwe.poeche@siemens.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 07 Jul 2020 10:19:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment