Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37168 )
Change subject: sb/amd/{agesa,pi}/hudson: add southbridge C bootblock initialization ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37168/5/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37168/5/src/southbridge/amd/agesa/h... PS5, Line 20: ifneq ($(CONFIG_ROMCC_BOOTBLOCK),y)
We should make the build work without this guard, I'll have a look.
Ack
https://review.coreboot.org/c/coreboot/+/37168/5/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/early_setup.c:
https://review.coreboot.org/c/coreboot/+/37168/5/src/southbridge/amd/agesa/h... PS5, Line 108: | DECODE_ENABLE_ADLIB_PORT;
Wanted to be as generic as possible to open routes for C bootblock console. […]
We can decide on this later. I am not so happy about these long names either.
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... PS1, Line 31: : ifeq ($(CONFIG_C_ENVIRONMENT_BOOTBLOCK),y)
Indeed these static functions in bootblock. […]
There is a cleanup at the end of patchtrain.
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... PS1, Line 64: #if CONFIG(C_ENVIRONMENT_BOOTBLOCK)
I also implemented bootblock_soc_early_init for AGESA, that is why I cared for other boards too.
Done