Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43804 )
Change subject: /soc/amd/acpi Move ACPI IVRS generation to coreboot
......................................................................
Patch Set 8:
(1 comment)
only had a very brief look, but will have a closer look on Monday and also test if it solves the IVRS-related error I get on mandolin
https://review.coreboot.org/c/coreboot/+/43804/8/src/include/acpi/acpi_ivrs....
File src/include/acpi/acpi_ivrs.h:
https://review.coreboot.org/c/coreboot/+/43804/8/src/include/acpi/acpi_ivrs....
PS8, Line 74: 1
(1 << 0) is more consistent with the rest
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43804
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I693f4399766c71c3ad53539634c65ba59afd0fe1
Gerrit-Change-Number: 43804
Gerrit-PatchSet: 8
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Jul 2020 00:07:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment