Attention is currently required from: Arthur Heymans, Patrick Rudolph, Wim Vervoorn.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52128 )
Change subject: soc/intel/braswell: CACHE_MRC_SETTINGS depends on !VBOOT_START_IN_ROMSTAGE
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
I noticed your concern in raminit_common(). […]
Tested CB:52157 which works fine!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52128
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfedfa82e746626f35e6f1d426a4de768c594b93
Gerrit-Change-Number: 52128
Gerrit-PatchSet: 7
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Comment-Date: Wed, 07 Apr 2021 13:43:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment