Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45654 )
Change subject: soc/intel/cannonlake: Align gpio_op.asl with TGL
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45654/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45654/7//COMMIT_MSG@14
PS7, Line 14: 2) Verify no ACPI error seen while running 'dmesg' from console.
Do you recommend me to add this line in test msg ? as i have ensured no changes with or without this […]
Yeah. I think that is generally helpful to know what tests have been run. Also, helpful when bisecting issues.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45654
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78d712eeba56b9c098dc6a6f11e4e51cb2529b10
Gerrit-Change-Number: 45654
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Fri, 25 Sep 2020 18:21:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subi.banik@gmail.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment