Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45229 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssh-f board as a variant ......................................................................
Patch Set 9:
(7 comments)
https://review.coreboot.org/c/coreboot/+/45229/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45229/8//COMMIT_MSG@9 PS8, Line 9: x11
X11
Done
https://review.coreboot.org/c/coreboot/+/45229/8//COMMIT_MSG@10 PS8, Line 10: Ethernet
ethernet
Done
https://review.coreboot.org/c/coreboot/+/45229/8//COMMIT_MSG@11 PS8, Line 11: and an integrated graphics device (though it has no output, it is said : to be able to be used for compute tasks, so I decide to enable it).
drop this, since it's not board-related but depends on which cpu one installs
Done
https://review.coreboot.org/c/coreboot/+/45229/8/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-f.md:
https://review.coreboot.org/c/coreboot/+/45229/8/Documentation/mainboard/sup... PS8, Line 23: it, (The onboard VGA port is connected to BMC) it
it (the onboard VGA port is connected to BMC), it
Done
https://review.coreboot.org/c/coreboot/+/45229/8/Documentation/mainboard/sup... PS8, Line 24: probably rendering graphics for BMC or other graphic cards to output via [vga_witcheroo]
Let's just drop mentioning BMC here, since it could confuse people. What about this? […]
Done
https://review.coreboot.org/c/coreboot/+/45229/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/45229/8/src/mainboard/supermicro/x1... PS8, Line 84:
PAD_NC(GPP_C23, NONE) got lost ;)
Done
https://review.coreboot.org/c/coreboot/+/45229/4/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/45229/4/src/mainboard/supermicro/x1... PS4, Line 97: PAD_CFG_STRUCT(GPP_C23, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) : | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE),
Done
Done