Attention is currently required from: Arthur Heymans.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80810?usp=email )
Change subject: arch/x86/car.ld: Move FSP RC heap region into car_region
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/80810/comment/55ae4a8c_7b1d7631 :
PS1, Line 11: #if CONFIG_FSP_M_RC_HEAP_SIZE > 0
I believe that I introduced a cbfstool change a while back which allow empty regions. My point is you should not need this `#if`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80810?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I44b127f8cdf5aa00e9f85a26f5abc290d0dfc11b
Gerrit-Change-Number: 80810
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 01 Mar 2024 16:26:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment