Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31416 )
Change subject: SMBIOS: Update BIOS Information (Type 0) to version V3.2.0 ......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Left some ideas for cosmetic cleanup, not in the scope of this change.
https://review.coreboot.org/#/c/31416/6/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31416/6/src/arch/x86/smbios.c@374 PS6, Line 374: uint32_t rom_size = CONFIG_ROM_SIZE; The initialization is futile, could be dropped.
https://review.coreboot.org/#/c/31416/6/src/arch/x86/smbios.c@376 PS6, Line 376: t->bios_rom_size = (rom_size / 65535) - 1; lol, this shold be `65536`, easier: `(64 * KiB)`.