Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42892 )
Change subject: acpi: Avoid freeing a device twice
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42892/2/src/acpi/device.c
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/42892/2/src/acpi/device.c@829
PS2, Line 829: acpi_dp_write(dp->child);
Right now the code seems to do exactly the same as before, just in two functions. Don't you have to change this to call acpi_dp_write_?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42892
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife3917af10bc35a3c3eee38d8292f927ef15409d
Gerrit-Change-Number: 42892
Gerrit-PatchSet: 2
Gerrit-Owner: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 18:10:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment