Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )
Change subject: autoport: Add support for Haswell-LynxPoint platform ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30890/11/util/autoport/lynxpoint.go File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/11/util/autoport/lynxpoint.go... PS11, Line 188: DSDTDefine{ : Key: "BRIGHTNESS_UP", : Value: "\_SB.PCI0.GFX0.INCB", : }, : DSDTDefine{ : Key: "BRIGHTNESS_DOWN", : Value: "\_SB.PCI0.GFX0.DECB", : }, : DSDTDefine{ : Key: "ACPI_VIDEO_DEVICE", : Value: "\_SB.PCI0.GFX0", : })
Those should be removed as they are unused in most cases
I meant all three values.
https://review.coreboot.org/c/coreboot/+/30890/11/util/autoport/lynxpoint.go... PS11, Line 309: .wdbbar = 0x4000000, : .wdbsize = 0x1000,
These should not be needed at all
Done
https://review.coreboot.org/c/coreboot/+/30890/12/util/autoport/lynxpoint.go File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/12/util/autoport/lynxpoint.go... PS12, Line 128: switch g { The indentation is rather odd here