Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30678 )
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... PS7, Line 55: 0
Is this the right value for this GPIO?
This GPIO goes to DPR pin of WWAN module. This is active low pin and if we make it 0, it enabled Dynamic Power Reduction(DPR) for WWAN based on proximity sensor inputs. I am changing it to 1, so we don't enable DPR by default and it can be handled by driver.
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... PS7, Line 72: /* WWAN_CONFIG_0 */ : PAD_CFG_GPI(GPP_D5, NONE, DEEP), : /* WWAN_CONFIG_1 */ : PAD_CFG_GPI(GPP_D6, NONE, DEEP), : /* WWAN_CONFIG_2 */ : PAD_CFG_GPI(GPP_D7, NONE, DEEP), : /* WWAN_CONFIG_3 */ : PAD_CFG_GPI(GPP_D8, NONE, DEEP),
Since we are not yet sure how or if this will be used, let's just configure it as NC.
Done
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... PS7, Line 113: 0
1?
Done