Hello Jes Klinke,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46436
to look at the new patch set (#2).
Change subject: volteer+vendorcode: Cr50 version code only via SPI ......................................................................
volteer+vendorcode: Cr50 version code only via SPI
No recent Chromebooks have used I2C for TPM communication, and as a result, a bug has crept in. The ability to extract Cr50 firmware string is only supported via SPI, yet code in mainboard and vendorcode attempts to do so unconditionally.
This CL makes it such that the code also compiles in case future designs will use I2C. (Whether we want to enhance the I2C protocol to be able to provide the version string, and then implement the support is a separate question.)
This effort is prompted by the desire to use reworked Volteer EVT devices for validating the new Ti50/Dauntless TPM, which will be connected via I2C in the upcoming designs.
TEST=util/abuild/abuild -t GOOGLE_VOLTEER -c max -x
Change-Id: Ida1d732e486b19bdff6d95062a3ac1a7c4b58b45 Signed-off-by: jbk@chromium.org --- M src/mainboard/google/volteer/mainboard.c M src/vendorcode/google/chromeos/cse_board_reset.c 2 files changed, 21 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/46436/2