Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )
Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Please do not submit this yet - the RAM ID may be wrong.
https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/...
PS2, Line 22: 0]
Hi @MTK, in Kukui RAM ID table this should be 8 instead of 0.
Can you double check with your hardware team?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27164f0909edb9d9398835e292fb845f0e342391
Gerrit-Change-Number: 34532
Gerrit-PatchSet: 2
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-Comment-Date: Thu, 01 Aug 2019 08:13:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment