Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )
Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor ......................................................................
Patch Set 9:
(3 comments)
Patch Set 7: Code-Review+1
(2 comments)
Is somebody working on unifying the camera ASL code, so it’s automatically generated for example? For example, besides some values, the structure is very similar to.
src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
Yes, here is the base patch https://review.coreboot.org/c/coreboot/+/41607
https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG@11 PS7, Line 11: BUG=None
No bug?
Updated.
https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG@14 PS7, Line 14: and able to capture image using world facing camera.
Did the camera work before?
This patch adds the VCM entries, earlier we were able to take raw capture. And now driver is able to control the VCM.
https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... PS6, Line 236: Device (NVM0)
It’d be great if you mentioned this in the commit message.
okay.