EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47640 )
Change subject: drivers/i2c: Add a driver for Semtech SX9324
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/chip...
File src/drivers/i2c/sx9324/chip.h:
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/chip...
PS2, Line 15: /* Device Name */
: const char *name;
Done
@Tim, uid can reflect each HIDs then driver will try the correspond property. I've tried print some log in kernel. In the feature we should care uid for this driver as well:)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd582482728a2f535ed85f6696b2f5a4529ba421
Gerrit-Change-Number: 47640
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Nov 2020 04:32:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment