Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38426 )
Change subject: lib: Always read SPD sources as text file
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38426/2/src/lib/Makefile.inc
File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38426/2/src/lib/Makefile.inc@341
PS2, Line 341: --binary-files=text
This looks very GNU to me, but I checked and it seems to be implemented ~everywhere for compatibility.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e5bad069531630b36dc3702c8c4bd94ba0946c1
Gerrit-Change-Number: 38426
Gerrit-PatchSet: 2
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 15 Jan 2020 16:48:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment