build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41949 )
Change subject: soc/mediatek/mt8183: Support 6GB, 8GB DDR bootup ......................................................................
Patch Set 2:
(26 comments)
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 334: .tx_ref_cnt = 42}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 334: .tx_ref_cnt = 42}, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 336: .tx_ref_cnt = 62}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 336: .tx_ref_cnt = 62}, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 338: .tx_ref_cnt = 82} }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 338: .tx_ref_cnt = 82} }, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 343: .tx_ref_cnt = 61}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 343: .tx_ref_cnt = 61}, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 345: .tx_ref_cnt = 91}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 345: .tx_ref_cnt = 91}, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 347: .tx_ref_cnt = 121} }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 347: .tx_ref_cnt = 121} }, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 352: .tx_ref_cnt = 79}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 352: .tx_ref_cnt = 79}, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 354: .tx_ref_cnt = 119}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 354: .tx_ref_cnt = 119}, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 356: .tx_ref_cnt = 159} }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 356: .tx_ref_cnt = 159} }, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 359: .tx_ref_cnt = 68}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 359: .tx_ref_cnt = 68}, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 361: .tx_ref_cnt = 92}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 361: .tx_ref_cnt = 92}, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 363: .tx_ref_cnt = 138}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 363: .tx_ref_cnt = 138}, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 365: .tx_ref_cnt = 185} }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41949/2/src/soc/mediatek/mt8183/emi... PS2, Line 365: .tx_ref_cnt = 185} }, please, no space before tabs