[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Use ACPIMMIO_BASE() in ASL

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42944 )

Change subject: soc/amd/common: Use ACPIMMIO_BASE() in ASL
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42944/2/src/mainboard/google/kahlee... 
File src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl:

https://review.coreboot.org/c/coreboot/+/42944/2/src/mainboard/google/kahlee... 
PS2, Line 21: Method (_CRS, 0x0, Serialized) {
            : 		Name (RBUF, ResourceTemplate () {
            : 			// Memory resource is for MISC FCH register set.
            : 			// It is needed for enabling the clock.
            : 			Memory32Fixed(ReadWrite, ACPIMMIO_BASE(MISC), 0x100)
            : 		})
            : 
            : 		Return (RBUF)
            : 	}
You can do the following:

Name (RBUF, ResourceTemplate () {
    	// Memory resource is for MISC FCH register set.
    	// It is needed for enabling the clock.
    	Memory32Fixed(ReadWrite, 0, 0x100, MISC)
    })

Method (_CRS, 0, Serialized) {
    	CreateDwordField (RBUF, ^MISC._BAS, MBAS)
    	MBAS = ACPIMMIO_BASE(MISC)
    	Return (RBUF)
    }