[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Hook up GMA ACPI brightness controls

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40593 )

Change subject: soc/intel/apollolake: Hook up GMA ACPI brightness controls
......................................................................

Patch Set 3:
> > I suggest that we add a Kconfig INTEL_GMA_PANEL_2 and override things
> > as follows:
> > config INTEL_GMA_BCLV_OFFSET
> >         default 0xc8358 if INTEL_GMA_PANEL_2
> >         default 0xc8258
> >
> > config INTEL_GMA_BCLV_WIDTH
> >         default 32
> >
> > config INTEL_GMA_BCLM_OFFSET
> >         default 0xc8354 if INTEL_GMA_PANEL_2
> >         default 0xc8254
> >
> > config INTEL_GMA_BCLM_WIDTH
> >         default 32
>
> what determines the use of panel 1 vs panel 2?

Board design, mostly. The current gma/acpi code assumes that there
is only one panel, so the mainboard code would have to select one.
I'm not sure if i915 supports multiple panels yet. That might make
things harder to synchronize between our ACPI code and i915...