Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29371 )
Change subject: drivers/intel/fsp1_1/raminit.c: Make check FSP HOBs independent of CONFIG_DISPLAY_HOBS
......................................................................
Patch Set 3:
Patch Set 3:
(3 comments)
Please clean up and separate HOB checking and HOB displaying. You have also enabled prints that are a part of displaying the hobs after removing the macro.
I don't agree 100% with your comment. The Hobs are handled the same way as FSP_BOOTLOADER_TOLUM_HOB and FSP_SMBIOS_MEMORY_INFO_HOB now.
We might consider if CONFIG_DISPLAY_HOBS should disable and hob information, but don't disable verification of the required hobs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29371
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3776fa37866c7ef3aea090842387660c22bbdd4d
Gerrit-Change-Number: 29371
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: York Yang
yyang024@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Apr 2019 14:03:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment