Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47350 )
Change subject: lp4x: Add new memory parts and generate SPDs ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47350/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47350/1//COMMIT_MSG@10 PS1, Line 10: generates SPDs using gen_spd.go for TGL This CL is not adding any new SPDs, nor are any new generic SPDs generated by adding these three parts to the global manifest. It uses three generic SPDs that already exist. Perhaps a better summary would be something like "This change adds the following memory parts to LP4x global list of available LP4x parts and to the global JSON file containing LP4x parts and their characteristics." or something like that?
https://review.coreboot.org/c/coreboot/+/47350/1//COMMIT_MSG@16 PS1, Line 16: build Please include commands used to verify these changes don't break SPD generation.
e.g. cd <path_to_coreboot_src>/util/spd_tools/lp4x && ./gen_spd <path_to_coreboot_src>/src/soc/intel/tigerlake/spd ./global_lp4x_mem_parts.json.txt "TGL"