Attention is currently required from: Raul Rangel, Aaron Durbin, Furquan Shaikh, Marshall Dawson, Julius Werner, Angel Pons. Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56047 )
Change subject: commonlib/bsd/future: Introduce future API ......................................................................
Patch Set 1: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56047/comment/d219a176_d8775828 PS1, Line 32: protected. Auditing this is complicated anid error prone. nit. "and"
Patchset:
PS1: couple of nits and questions. no fundamental objections.
File src/commonlib/bsd/include/commonlib/bsd/future.h:
https://review.coreboot.org/c/coreboot/+/56047/comment/dd22119b_dadf0d66 PS1, Line 1: /* SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0-or-later */ curious - why did this go in bsd?
https://review.coreboot.org/c/coreboot/+/56047/comment/35472148_6006ad17 PS1, Line 37: * periodically poll until the second transaction completes. Once the chaining here to start a decompress would also be useful. "AndThenFut". Do we need a provision for that as wll?
https://review.coreboot.org/c/coreboot/+/56047/comment/166e8cad_eccad226 PS1, Line 40: * By only polling periodically, we allow the CPU is to continue nit "is to"
https://review.coreboot.org/c/coreboot/+/56047/comment/986e69b5_9a143d52 PS1, Line 68: * those dependents should be polled by the containing future and not the not quite following this. The contract for future trait says once a future is complete, it is no longer checked. Wouldn't you want the dependent future to poll the parent in that case?