Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu...
PS9, Line 39: uint32_t get_board_sku(void);
No need to re-introduce this function.
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/foob/variant.c:
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu...
PS9, Line 55: uint32_t sku_id = get_board_sku();
Please use google_chromeec_get_board_sku() like in line 34 instead of get_board_sku().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39424
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e
Gerrit-Change-Number: 39424
Gerrit-PatchSet: 9
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tommie Lin
tong.lin@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-Comment-Date: Mon, 16 Mar 2020 20:53:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment