Attention is currently required from: Bora Guvendik, Hannah Williams, Jérémy Compostella.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74141 )
Change subject: soc/intel/cmn/pcie: Allow SoC to overwrite snoop/no-snoop latency
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74141/comment/4357eeb8_ae2f7976
PS4, Line 10: tolerance, let it overwrite the common code settings.
by implementing weak the function
Why did you chose this way?
File src/soc/intel/common/block/pcie/pcie.c:
https://review.coreboot.org/c/coreboot/+/74141/comment/1cf817d3_c563059e
PS4, Line 14: __weak
What is coreboot recommendation or guideline in this case? […]
I could not find a document, but there are discussions on Gerrit. I couldn’t find it with the Gerrit search though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2b9a158d219e6c6e7f6e7f0ae0f093c1183b402
Gerrit-Change-Number: 74141
Gerrit-PatchSet: 5
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 06:41:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bora Guvendik
bora.guvendik@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment