Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33386 )
Change subject: vboot: use vboot2 API to set initial secdatak value
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33386/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33386/1//COMMIT_MSG@18
PS1, Line 18: TEST=make clean && make test-abuild
Done. Not sure if it's the prettiest commit message.
Done
https://review.coreboot.org/c/coreboot/+/33386/1/src/security/vboot/secdata_...
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/33386/1/src/security/vboot/secdata_...
PS1, Line 232: VB2_SECDATAK_SIZE
Nah, it looks like you are quite adept at mathematics =) […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74261453df6cc55ef3f38d8fb922bcc604084c0a
Gerrit-Change-Number: 33386
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Aug 2019 04:30:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment