Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32834 )
Change subject: Documentation: Convert Intel to markdown ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/#/c/32834/1/Documentation/Intel/Board/board.md File Documentation/Intel/Board/board.md:
https://review.coreboot.org/#/c/32834/1/Documentation/Intel/Board/board.md@1... PS1, Line 16: [Required Files]{#RequiredFiles} not valid markdown headers
https://review.coreboot.org/#/c/32834/1/Documentation/Intel/Board/board.md@2... PS1, Line 26: A. Selects the SoC for the board and specifies the SPI flash size A. / B. are not threaded as list iterators
https://review.coreboot.org/#/c/32834/1/Documentation/Intel/Board/board.md@2... PS1, Line 27: I. BOARD_ROMSIZE_KB_<Size> no need for _< / >
https://review.coreboot.org/#/c/32834/1/Documentation/Intel/SoC/soc.md File Documentation/Intel/SoC/soc.md:
https://review.coreboot.org/#/c/32834/1/Documentation/Intel/SoC/soc.md@398 PS1, Line 398: static void pci_set_subsystem(struct device *dev, unsigned vendor, unsigned device) use a block for code highlighting: ```c
code
```
https://review.coreboot.org/#/c/32834/1/Documentation/Intel/SoC/soc.md@457 PS1, Line 457: coreboot Field EDK2 Field gUefiAcpiBoardInfoGuid Use seems broken
https://review.coreboot.org/#/c/32834/1/Documentation/Intel/fsp1_1.md File Documentation/Intel/fsp1_1.md:
https://review.coreboot.org/#/c/32834/1/Documentation/Intel/fsp1_1.md@69 PS1, Line 69: Modified: 17 May 2016 can be dropped, sphinx will automatically update this
https://review.coreboot.org/#/c/32834/1/Documentation/Intel/index.md File Documentation/Intel/index.md:
https://review.coreboot.org/#/c/32834/1/Documentation/Intel/index.md@88 PS1, Line 88: [e820](https://en.wikipedia.org/wiki/E820) [dmesg](http://manpages.ubuntu.com/manpages/trusty/man1/dmesg.1.html) whitespace errors