Raul Rangel has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62349 )
Change subject: soc/amd/common/fsp/fsp_validate.c: print warning instead of error ......................................................................
soc/amd/common/fsp/fsp_validate.c: print warning instead of error
If an AMD FSP binary has no valid image revision information, print a warning instead of an error.
Change-Id: Ie9c5a387b81205fe93382778090260e41e261776 Signed-off-by: Julian Schroeder julianmarcusschroeder@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/62349 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Jason Glenesk jason.glenesk@gmail.com Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/fsp/fsp_validate.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Raul Rangel: Looks good to me, approved Jason Glenesk: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/common/fsp/fsp_validate.c b/src/soc/amd/common/fsp/fsp_validate.c index d9ff502..0ce59b3 100644 --- a/src/soc/amd/common/fsp/fsp_validate.c +++ b/src/soc/amd/common/fsp/fsp_validate.c @@ -27,7 +27,7 @@ /* a coding bug on the AMD FSP side makes this value 1 in older versions of the FSP.*/ if (hdr->image_revision == 1) { - printk(BIOS_ERR, "No AMD FSP image revision information available\n"); + printk(BIOS_WARNING, "No AMD FSP image revision information available\n"); return; }