Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41159 )
Change subject: mainboard: Add HP EliteBook 2560p ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/41159/2/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/2560p/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41159/2/src/mainboard/hp/snb_ivb_la... PS2, Line 8: 0x0 0
https://review.coreboot.org/c/coreboot/+/41159/2/src/mainboard/hp/snb_ivb_la... PS2, Line 12: Add an extra space to align the "end" words?
https://review.coreboot.org/c/coreboot/+/41159/2/src/mainboard/hp/snb_ivb_la... PS2, Line 21: 1 I don't think the SD/MMC Host Controller is hotpluggable