Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29009 )
Change subject: amd/stoneyridge: Convert hex definitions to lower case ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge.... File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 593: cfg5 |= (0x2 << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT) & CG1PLL_SS_AMOUNT_NFRAC_SLIP_MA This line is probably also over 80 characters. If you fix the others, please fix this one too.