[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Init SPM driver

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )

Change subject: mediatek/mt8183: Init SPM driver
......................................................................

Patch Set 16:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34545/14/src/soc/mediatek/mt8183/in... 
File src/soc/mediatek/mt8183/include/soc/spm.h:

https://review.coreboot.org/c/coreboot/+/34545/14/src/soc/mediatek/mt8183/in... 
PS14, Line 476: check_member(mtk_spm_regs, poweron_config_set, 0x0000);
              : check_member(mtk_spm_regs, spm_power_on_val0, 0x0004);
              : check_member(mtk_spm_regs, spm_power_on_val1, 0x0008);
              : check_member(mtk_spm_regs, spm_clk_con, 0x000c);
              : check_member(mtk_spm_regs, pcm_con0, 0x0018);
              : check_member(mtk_spm_regs, pcm_con1, 0x001c);
              : check_member(mtk_spm_regs, pcm_im_ptr, 0x0020);
              : check_member(mtk_spm_regs, pcm_im_len, 0x0024);
              : check_member(mtk_spm_regs, pcm_reg_data_ini, 0x0028);
              : check_member(mtk_spm_regs, pcm_pwr_io_en, 0x002c);
              : check_member(mtk_spm_regs, pcm_im_host_rw_ptr, 0x0038);
              : check_member(mtk_spm_regs, pcm_im_host_rw_dat, 0x003c);
              : check_member(mtk_spm_regs, pcm_event_vector0, 0x0040);
              : check_member(mtk_spm_regs, pcm_event_vector1, 0x0044);
              : check_member(mtk_spm_regs, pcm_event_vector2, 0x0048);
              : check_member(mtk_spm_regs, pcm_event_vector3, 0x004c);
              : check_member(mtk_spm_regs, pcm_event_vector4, 0x0050);
              : check_member(mtk_spm_regs, pcm_event_vector5, 0x0054);
              : check_member(mtk_spm_regs, pcm_event_vector6, 0x0058);
              : check_member(mtk_spm_regs, pcm_event_vector7, 0x005c);
              : check_member(mtk_spm_regs, pcm_event_vector8, 0x0060);
              : check_member(mtk_spm_regs, pcm_event_vector9, 0x0064);
              : check_member(mtk_spm_regs, pcm_event_vector10, 0x0068);
              : check_member(mtk_spm_regs, pcm_event_vector11, 0x006c);
              : check_member(mtk_spm_regs, pcm_event_vector12, 0x0070);
              : check_member(mtk_spm_regs, pcm_event_vector13, 0x0074);
              : check_member(mtk_spm_regs, pcm_event_vector14, 0x0078);
              : check_member(mtk_spm_regs, pcm_event_vector15, 0x007c);
              : check_member(mtk_spm_regs, spm_swint_clr, 0x0094);
              : check_member(mtk_spm_regs, spm_cpu_wakeup_event, 0x00b0);
              : check_member(mtk_spm_regs, spm_irq_mask, 0x00b4);
              : check_member(mtk_spm_regs, spm_wakeup_event_mask, 0x00c4);
              : check_member(mtk_spm_regs, ddr_en_dbc_len, 0x00d8);
> Do you mean that we don't need to check every register what we use, just check the few critical regi […]

yes