22 Sep
2021
22 Sep
'21
3:41 p.m.
Attention is currently required from: Furquan Shaikh, Reka Norman, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57773 )
Change subject: util/spd_tools: Sort platforms_manifest entries by set number ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File util/spd_tools/src/spd_gen/spd_gen.go:
https://review.coreboot.org/c/coreboot/+/57773/comment/88f1dcd3_f6c0138f PS2, Line 195: , 0
Yes, without it I get: […]
Sorry go n00b here 🤓
--
To view, visit https://review.coreboot.org/c/coreboot/+/57773
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bfea65c8fc781df80a8725c0cf20c7547c857e8
Gerrit-Change-Number: 57773
Gerrit-PatchSet: 3
Gerrit-Owner: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Wed, 22 Sep 2021 15:41:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Reka Norman rekanorman@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment