Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40762 )
Change subject: src/cpu/x86/mtrr/earlymtrr: Validate MTRR arguments
......................................................................
Patch Set 3:
(2 comments)
Nice. Let’s see what is reported on current devices.
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG@7
PS3, Line 7: src/cpu/x86/mtrr/earlymtrr: Validate MTRR arguments
Please remove `src/` from the beginning.
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG@18
PS3, Line 18: 2 n
2^n
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b8c734c7599bd89cf9f212ed43c2dd5b2c8ba7b
Gerrit-Change-Number: 40762
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 13:27:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment