Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37783 )
Change subject: soc/intel/tigerlake: Update chip files
......................................................................
Patch Set 12: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/37783/6/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/37783/6/src/soc/intel/tigerlake/chi...
PS6, Line 119: Audio related
Some/all of these configs are going to be used eventually for enabling audio. […]
We'll keep the variable so that we can avoid auto build failure in JSL.
And we'll update this with JSL, TGL together with devicetree change
https://review.coreboot.org/c/coreboot/+/37783/6/src/soc/intel/tigerlake/chi...
PS6, Line 167: /* Statically clock gate 8254 PIT. */
: uint8_t clock_gate_8254;
Note used: Remove
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1518a7ffa69079fe82232afe229d9e1ffe29067
Gerrit-Change-Number: 37783
Gerrit-PatchSet: 12
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Jan 2020 02:05:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment