31 Dec
2019
31 Dec
'19
9:59 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38012 )
Change subject: nb/intel/sandybridge: add and use ME stolen memory and lock bit defines ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38012/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/38012/1/src/northbridge/intel/sandy... PS1, Line 612: reg = reg | MELCK; // set lockbit on ME mem Just curious of the line swap. I hope the datasheet does not mention that hardware requires a split enable / lock sequence instead of a single write here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4663498b10a5eedcc1aa51088b984ecc49ef23e
Gerrit-Change-Number: 38012
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 31 Dec 2019 08:59:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment