[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Disable XHCI LFPS power management

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40255 )

Change subject: soc/intel/apollolake: Disable XHCI LFPS power management
......................................................................

Patch Set 21:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40255/19/src/soc/intel/apollolake/c... 
File src/soc/intel/apollolake/chip.h:

https://review.coreboot.org/c/coreboot/+/40255/19/src/soc/intel/apollolake/c... 
PS19, Line 192:  * 0:FALSE (default), 1:True.
> proposed to change it to: […]

Looks good, thanks.

https://review.coreboot.org/c/coreboot/+/40255/19/src/soc/intel/apollolake/c... 
PS19, Line 194: 	uint8_t DisableXhciLfpsPM;
> referring to other variables in "chip.h" such as "enable_vtd" which is also "uint8_t". […]

Well, a bool is a typedef for an uint8_t, so they should be equivalent. In any case, since even ints are used for boolean values (`int dptf_enable`), this can be changed in a follow-up.