Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46861 )
Change subject: drivers/wifi/generic: Split wifi_generic_fill_ssdt into two functions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46861/1/src/drivers/wifi/generic/ac... File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/46861/1/src/drivers/wifi/generic/ac... PS1, Line 181: dev->chip_info
That was the part I deleted because I wasn't sure.. "unless it can't handle the lack of chip_info... […]
Yeah, I think it was done to ensure config is not NULL. But, I agree the hidden `die()` gets missed. Wonder if we need a different helper so that the callers don't need to care about accessing the internals of the device structure, but still can do their own checks.