Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45235 )
Change subject: libpayload: cbgfx: Fix 'equals' counter for Lanczos resampling ......................................................................
Patch Set 3:
(1 comment)
Thanks for the explanation, makes perfect sense now! Main patch LGTM, only the last_sample addtion still seems weird (and unrelated?) to me.
https://review.coreboot.org/c/coreboot/+/45235/3/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/45235/3/payloads/libpayload/drivers... PS3, Line 882: sample[sx][sy] = *last_sample; I'm confused what you're trying to add with the whole last_sample thing, it doesn't seem to be necessary? Are you just trying to save a call to pal_to_rgb()? I kinda doubt that's worth it... but if you want to add it you should also add it to the loop in line 922 for consistency (that's really the more important one). (I'm also not sure if making it a pointer or a normal struct rgb variable would be more efficient...)