Attention is currently required from: Felix Held, Martin Roth, Paul Menzel.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78221?usp=email )
Change subject: soc/amd/genoa: Add SMI support
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78221/comment/65826f69_ff086d16 :
PS1, Line 8:
Please elaborate. […]
Done
File src/soc/amd/genoa/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/78221/comment/15e5d351_e6cec1b3 :
PS1, Line 8: /* @Todo: Update the SMI details for Genoa */
Any reason this is left as a TODO instead of doing it before the patch is submitted?
Done
https://review.coreboot.org/c/coreboot/+/78221/comment/a66968d8_c94d95b7 :
PS1, Line 26: #define SMITYPE_G_GENINT2_L 1
this table doesn't seem to be updated for genoa yet; this entry should for example be […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78221?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I491f4075cef8976e4b0762752c9e2e3c2ef886d5
Gerrit-Change-Number: 78221
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 06 Oct 2023 14:11:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment