Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38941 )
Change subject: nb/intel/nehalem: Rename to ironlake ......................................................................
Patch Set 4:
Why are the cpu/ changes part of this patch? Why use `ironlake` in cpu/? e.g. IRONLAKE_BCLK, is it related to the SA?
Well, I basically did `s/nehalem/ironlake/g` and `s/NEHALEM/IRONLAKE/g` under src/. It was the simplest way to rename a bunch of instances without affecting prints.
Please mention such automatism in commit messages.
Also, the CPU and the SA are always connected together. Sure, the "Ironlake" name under src/cpu/ might be weird, but it is more correct than Nehalem.
With regard to `IRONLAKE_BCLK`, it is indeed related to the SA: it is the only BCLK it supports. Moreover, I would say that "HILLEL_BCLK" is too obscure (Hillel is the name of the 32nm CPU die), and CLARKDALE_ARRANDALE_BCLK` is just obnoxiously long. Therefore, I would prefer that bikeshedding be left out of this change.
Fair enough.