[coreboot-gerrit] Change in coreboot[master]: [WIP,RFC] soc/amd/common: Place some ENV_X86 guards

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42523 )

Change subject: [WIP,RFC] soc/amd/common: Place some ENV_X86 guards
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42523/7/src/soc/amd/picasso/i2c.c 
File src/soc/amd/picasso/i2c.c:

https://review.coreboot.org/c/coreboot/+/42523/7/src/soc/amd/picasso/i2c.c@5... 
PS7, Line 55: 	switch (dev->path.mmio.addr) {
> Yes, but it won't be called. garbage collection will remove them.

I did not look deep into this yet but looks to me that i2c controller enablement does not respond the excepted way when some i2c controllers are disabled in devicetree.

In similar fashion, the SOC code makes assumptions for pads, configuring pins to i2c use and excepts platform code to override those. Shouldn't it be the other way around such that mainboard/variant has (full) control of the pads?