[coreboot-gerrit] Change in coreboot[master]: nb/intel/nehalem: Move to C_ENVIRONMENT_BOOTBLOCK

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35951 )

Change subject: nb/intel/nehalem: Move to C_ENVIRONMENT_BOOTBLOCK
......................................................................

Patch Set 4: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... 
File src/northbridge/intel/nehalem/Kconfig:

https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... 
PS3, Line 25: 	select BOOTBLOCK_CONSOLE
> > Didn't we decide to leave this choice to the user? […]

Thanks.

https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... 
File src/northbridge/intel/nehalem/romstage.c:

https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... 
PS3, Line 51: 	console_init();
> > No console_init() in romstage? […]

Ack, did mis-grep that...