Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60494 )
Change subject: soc/intel/apollolake/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ......................................................................
soc/intel/apollolake/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
Replace `Add (a, b, c)` with `c = a + b`.
Change-Id: I4d6039affd9688a2e795d69f699d5baf688ba2e4 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/60494 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/soc/intel/apollolake/acpi/gpiolib.asl M src/soc/intel/apollolake/acpi/northbridge.asl 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/acpi/gpiolib.asl b/src/soc/intel/apollolake/acpi/gpiolib.asl index 0ec9140..e01d549 100644 --- a/src/soc/intel/apollolake/acpi/gpiolib.asl +++ b/src/soc/intel/apollolake/acpi/gpiolib.asl @@ -69,7 +69,7 @@ Method (CHSA, 0x1, Serialized) { /* Arg0 - GPIO pad offset relative to the community */ - Add (HOSTSW_OWN_REG_0, Multiply (Divide (Arg0, 32), 4), Local1) + Local1 = HOSTSW_OWN_REG_0 + Multiply (Divide (Arg0, 32), 4) Return (Local1) }
diff --git a/src/soc/intel/apollolake/acpi/northbridge.asl b/src/soc/intel/apollolake/acpi/northbridge.asl index 929bdd1..1b59097 100644 --- a/src/soc/intel/apollolake/acpi/northbridge.asl +++ b/src/soc/intel/apollolake/acpi/northbridge.asl @@ -83,7 +83,7 @@ And(_SB.PCI0.MCHC.MCNF, 0xF0000000, PMAX)
/* Calculate PCI MMIO Length */ - Add(Subtract(PMAX, PMIN), 1, PLEN) + PLEN = Subtract(PMAX, PMIN) + 1
/* Find GFX resource area in GCRS */ CreateDwordField(MCRS, STOM._MIN, GMIN) @@ -96,7 +96,7 @@ /* Read TOLUD */ And(_SB.PCI0.MCHC.TLUD, 0xFFF00000, GMAX) Decrement(GMAX) - Add(Subtract(GMAX, GMIN), 1, GLEN) + GLEN = Subtract(GMAX, GMIN) + 1
/* Patch PM02 range based on Memory Size */ If (LEqual (A4GS, 0)) {
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.