Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31791 )
Change subject: util/intelmetool: Add support for Apollolake
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31791/1/util/intelmetool/intelmetool.h
File util/intelmetool/intelmetool.h:
https://review.coreboot.org/#/c/31791/1/util/intelmetool/intelmetool.h@266
PS1, Line 266: #define PCI_DEV_HAS_SUPPORTED_ME(x) ( \
I'd not use this define as it's not a ME, but a TXE.
Having PCI_DEV_HAS_SUPPORTED_TXE(x) would allow to probe for TXE.
For bootguard support you must also test if PCI_DEV_HAS_SUPPORTED_TXE() and version is >= 3.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f8ef88d2fcc4bff4e7f56fbe5199fb534ae66d1
Gerrit-Change-Number: 31791
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
migy@darmstadt.ccc.de
Gerrit-Reviewer: Felix Singer
migy@darmstadt.ccc.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 Mar 2019 07:35:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment