21 Feb
2019
21 Feb
'19
5:22 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31531 )
Change subject: intelvbttool: Added support for reading vbt from sysfs ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Tested. Works fine.
https://review.coreboot.org/#/c/31531/3/util/intelvbttool/intelvbttool.c File util/intelvbttool/intelvbttool.c:
https://review.coreboot.org/#/c/31531/3/util/intelvbttool/intelvbttool.c@409 PS3, Line 409: if (read_size == 0) add comment when this could happen. A regular user would wonder why we attempt to read a zero sized file.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31531
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d17095a5747550b7115a54a7619b7294a846196
Gerrit-Change-Number: 31531
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Feinman alexfeinman@hotmail.com
Gerrit-Reviewer: Alex Feinman alexfeinman@hotmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 Feb 2019 17:22:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment