Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36207 )
Change subject: ec/google/chromeec: Add EC driver support for software sync ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36207/2/src/ec/google/chromeec/ec.h File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/36207/2/src/ec/google/chromeec/ec.h... PS2, Line 189: /*
Please be consistent with line breaks in between function headers.
Sure, my bad.
https://review.coreboot.org/c/coreboot/+/36207/2/src/ec/google/chromeec/ec.h... PS2, Line 191: u32 o
Arguments should line up with "(".
Ugh, I need to fix my emacs indentation setup.
https://review.coreboot.org/c/coreboot/+/36207/2/src/ec/google/chromeec/ec.h... PS2, Line 198: u32
I'm not totally sure if coreboot specifies that u32 or uint32_t format should be used, but seems lik […]
This file already used both styles (see google_chromeec_i2c_xfer vs. google_chromeec_set_sku_id). I'll pick one and clean it up.