Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45714 )
Change subject: sb/intel/lynxpoint: Use `config_of` where possible ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
https://review.coreboot.org/c/coreboot/+/45714/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45714/1//COMMIT_MSG@9 PS1, Line 9: This eliminates the need to perform null-checking. Use it in places where null-checks are missing.
https://review.coreboot.org/c/coreboot/+/45714/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/45714/1/src/southbridge/intel/lynxp... PS1, Line 148: struct southbridge_intel_lynxpoint_config *config = config_of(dev); Not a good idea
https://review.coreboot.org/c/coreboot/+/45714/1/src/southbridge/intel/lynxp... PS1, Line 500: struct southbridge_intel_lynxpoint_config *config = config_of(dev); Not a good idea