Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46599 )
Change subject: soc/intel/xeon_sp/skx/acpi.c: Update with cpx changes ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46599/1/src/soc/intel/xeon_sp/skx/a... File src/soc/intel/xeon_sp/skx/acpi.c:
https://review.coreboot.org/c/coreboot/+/46599/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 93: for (int socket = 0; socket < hob->PlatformData.numofIIO; ++socket) {
Where did the for-socket loop go?
Into the get_iiostack_info call.
https://review.coreboot.org/c/coreboot/+/46599/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 242: return NULL;
Huh? Is this intentional? […]
It was never called. void generate_t_state_entries(int core, int cores_per_package) was empty. It isn't called used in cpx either. We really don't need more steps to the next patch to combine these files.